Conversation
This commit improves the V2 navigation rail (V2Navi) by: - Converting the brand logo from a static div to a functional Link to the dashboard. - Implementing dynamic state for the Theme Toggle to update icons (dark_mode/light_mode) and ARIA labels based on the active theme. - Adding micro-animations (scale and rotation) to the Theme Toggle for a more tactile and delightful experience. - Improving accessibility by adding descriptive aria-labels and titles to the logo and theme toggle. - Updating and expanding unit tests to verify the new functionality. - Updating Palette's journal with learnings from this task. Co-authored-by: godie <227743+godie@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎨 Palette: V2 Navigation Rail UX Enhancement
This PR introduces a series of micro-UX improvements to the ENARM V2 navigation rail, focusing on accessibility, functionality, and "delight."
💡 What
Linkpointing to/v2/dashboard.dark_modevslight_mode) and itsaria-label/title("Cambiar a modo oscuro" vs "Cambiar a modo claro") with the document's actual theme.V2Navi.test.jsxto cover the new logo link and the dynamic theme toggle behavior.🎯 Why
Standardizing navigation patterns (like a clickable logo) makes the app more intuitive. Providing clear, localized feedback on state-changing buttons (like the theme toggle) improves both the perceived quality and the accessibility for screen reader users.
♿ Accessibility
aria-labelandtitleto the brand logo link.aria-labelfor the theme toggle.✅ Verification
V2Navi.test.jsxpass.PR created automatically by Jules for task 3576218090307781981 started by @godie